llama90 commented on PR #38502: URL: https://github.com/apache/arrow/pull/38502#issuecomment-1803610189
@js8544 Could you please confirm if this is the correct approach? Per your guidance, I've implemented changes using the `Visitor Pattern`. The following improvements appear to have been achieved: * Eliminated the need for branching when sorting Dictionary Types. * Removed unnecessary code that was previously part of the branches. I have some concerns regarding the cleanliness of the code. Additionally, while I have currently added unit tests for `string` and `int32` types, I'm considering extending them to cover all possible ranges. Would that be appropriate? Your input has been invaluable, and I've learned a great deal from this experience. Thank you. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
