alamb commented on issue #8008: URL: https://github.com/apache/arrow-datafusion/issues/8008#issuecomment-1803685037
I think the reasoning in this ticket makes sense to me. Thank you for raising it @gruuya I do agree with @waynexia that adding a `Expr::QualifiedAlias` would both be confusing as well make subtle bugs more likely (e.g. using `Expr::Alias` instead of using `Expr::QualiiedAlias`) and thus adding an optional `relation` to `Expr::Alias` is probably the "cleanest" way to do this Adding such a field would, of course, as @gruuya says, force us to go through many locations in the code to add handling of the new `relation` but this is probably a valuable exercise to ensure the relation is handled when appropriate Perhaps @jackwener or @liukun4515 or @ozankabak have some additional thoughts to share -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
