pitrou commented on a change in pull request #9130:
URL: https://github.com/apache/arrow/pull/9130#discussion_r557408484
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -1416,6 +1435,11 @@ cdef class DirectoryPartitioning(Partitioning):
----------
schema : Schema
The schema that describes the partitions present in the file path.
+ dictionaries : List[Array]
+ If the type of any field of `schema` is a dictionary type, the
+ corresponding entry of `dictionaries` must be an array containing
+ every value which may be taken by the corresponding column or an
+ error will be raised in parsing.
Review comment:
This seems a bit weird and inconvenient as an API. Why not accept a
`Dict[str, Array]` mapping field names to dictionaries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
