llama90 commented on PR #38504: URL: https://github.com/apache/arrow/pull/38504#issuecomment-1804095631
@js8544 Hello. I've done as you mentioned. I've now utilized `typename T::offset_type` to accommodate type-specific maximum lengths. Additionally, I've included tests for `String` and `LargeString` to ensure verification. Furthermore, I've put in place checks for when the length exceeds the `maximum` allowed size or is `negative`. Do you think these checks could be excessive? Thank you for your insightful review. It has certainly helped in refining my approach and making sure all bases are covered. Your guidance is greatly appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
