JacobOgle commented on code in PR #8100:
URL: https://github.com/apache/arrow-datafusion/pull/8100#discussion_r1388412596
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -1645,6 +1646,13 @@ pub fn parse_expr(
)),
ScalarFunction::Isnan => Ok(isnan(parse_expr(&args[0],
registry)?)),
ScalarFunction::Iszero => Ok(iszero(parse_expr(&args[0],
registry)?)),
+ ScalarFunction::ArrowTypeof => {
+ Ok(arrow_typeof(parse_expr(&args[0], registry)?))
+ }
+ ScalarFunction::ToTimestamp => {
+ Ok(to_timestamp_seconds(parse_expr(&args[0], registry)?))
+ }
+ ScalarFunction::Flatten => Ok(flatten(parse_expr(&args[0],
registry)?)),
_ => Err(proto_error(
"Protobuf deserialization error: Unsupported scalar
function",
)),
Review Comment:
Not a problem! I will start chipping away at the last two enum variants here
in a bit. Thanks for the feedback and openness allowing the contribution! 🙏
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -1645,6 +1646,13 @@ pub fn parse_expr(
)),
ScalarFunction::Isnan => Ok(isnan(parse_expr(&args[0],
registry)?)),
ScalarFunction::Iszero => Ok(iszero(parse_expr(&args[0],
registry)?)),
+ ScalarFunction::ArrowTypeof => {
+ Ok(arrow_typeof(parse_expr(&args[0], registry)?))
+ }
+ ScalarFunction::ToTimestamp => {
+ Ok(to_timestamp_seconds(parse_expr(&args[0], registry)?))
+ }
+ ScalarFunction::Flatten => Ok(flatten(parse_expr(&args[0],
registry)?)),
_ => Err(proto_error(
"Protobuf deserialization error: Unsupported scalar
function",
)),
Review Comment:
Not a problem! I will start chipping away at the last two enum variants here
in a bit. Thanks for the feedback and openness allowing the contribution! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
