leihou6116 opened a new pull request, #38661:
URL: https://github.com/apache/arrow/pull/38661

   ### Rationale for this change
   
   The current conversion from MATLAB duration to `arrow.array.Time32Array` and 
`arrow.array.Time64Array` loses time precision, and there is no test to cover 
such limitation. It is best practice to have tests cover software design. In 
addition, such tests will be helpful to evaluate the impact in the future when 
we improve the design.  
   
   ### What changes are included in this PR?  
   
   I mainly added three test cases for each of `arrow.array.Time32Array` and 
`arrow.array.Time64Array`.
   
   - Updated the basic test case to verify both class and value. In the MATLAB 
interface tests, we would like to verify the value to make sure there is no 
precision loss. The basic test case will serve as a test example when people 
learn to write tests. Updating the basic test case will set a good example for 
contributors to learn. 
   - Test the default value of "TimeUnit".
   - Test the functionality of "TimeUnit".
   
   ### Are these changes tested?
   
   No software change. The updated test files passed on my local machine.
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to