indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1388615004
##########
cpp/src/arrow/flight/client.h:
##########
@@ -383,6 +383,27 @@ class ARROW_FLIGHT_EXPORT FlightClient {
return DoExchange({}, descriptor);
}
+ /// \\brief Set server session option(s) by key/value. Sessions are generally
+ /// persisted via HTTP cookies.
+ /// \param[in] options Per-RPC options
+ /// \param[in] request The server session options to set
+ ::arrow::Result<SetSessionOptionsResult> SetSessionOptions(
+ const FlightCallOptions& options, const SetSessionOptionsRequest&
request);
+
+ /// \\brief Get the current server session options. The session is generally
+ /// accessed via an HTTP cookie.
+ /// \param[in] options Per-RPC options
+ /// \param[in] request The GetSessionOptions request object.
+ ::arrow::Result<GetSessionOptionsResult> GetSessionOptions(
+ const FlightCallOptions& options, const GetSessionOptionsRequest&
request);
+
+ /// \\brief Close/invalidate the current server session. The session is
generally
+ /// accessed via an HTTP cookie.
+ /// \param[in] options Per-RPC options
+ /// \param[in] request The CloseSession request object.
Review Comment:
It's empty, which you discover when you go look at constructing one, as with
several other messages in the wire protocol. I think we're ok as-is? It was
originally left out of the interface but a caller can (upon looking at what the
request object is) simply pass {}.
##########
cpp/src/arrow/flight/client.h:
##########
@@ -383,6 +383,27 @@ class ARROW_FLIGHT_EXPORT FlightClient {
return DoExchange({}, descriptor);
}
+ /// \\brief Set server session option(s) by key/value. Sessions are generally
+ /// persisted via HTTP cookies.
+ /// \param[in] options Per-RPC options
+ /// \param[in] request The server session options to set
+ ::arrow::Result<SetSessionOptionsResult> SetSessionOptions(
+ const FlightCallOptions& options, const SetSessionOptionsRequest&
request);
+
+ /// \\brief Get the current server session options. The session is generally
+ /// accessed via an HTTP cookie.
+ /// \param[in] options Per-RPC options
+ /// \param[in] request The GetSessionOptions request object.
Review Comment:
[Repeated from equivalent situation elsewhere:] It's empty, which you
discover when you go look at constructing one, as with several other messages
in the wire protocol. I think we're ok as-is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
