Light-City commented on code in PR #38642:
URL: https://github.com/apache/arrow/pull/38642#discussion_r1388956928
##########
cpp/src/arrow/testing/gtest_util.h:
##########
@@ -221,18 +221,22 @@ ARROW_TESTING_EXPORT void AssertScalarsEqual(
ARROW_TESTING_EXPORT void AssertScalarsApproxEqual(
const Scalar& expected, const Scalar& actual, bool verbose = false,
const EqualOptions& options = TestingEqualOptions());
-ARROW_TESTING_EXPORT void AssertBatchesEqual(const RecordBatch& expected,
- const RecordBatch& actual,
- bool check_metadata = false);
-ARROW_TESTING_EXPORT void AssertBatchesApproxEqual(const RecordBatch& expected,
- const RecordBatch& actual);
-ARROW_TESTING_EXPORT void AssertChunkedEqual(const ChunkedArray& expected,
- const ChunkedArray& actual);
-ARROW_TESTING_EXPORT void AssertChunkedEqual(const ChunkedArray& actual,
- const ArrayVector& expected);
+ARROW_TESTING_EXPORT void AssertBatchesEqual(
+ const RecordBatch& expected, const RecordBatch& actual, bool
check_metadata = false,
+ const EqualOptions& options = TestingEqualOptions());
+ARROW_TESTING_EXPORT void AssertBatchesApproxEqual(
+ const RecordBatch& expected, const RecordBatch& actual,
+ const EqualOptions& options = TestingEqualOptions());
+ARROW_TESTING_EXPORT void AssertChunkedEqual(
+ const ChunkedArray& expected, const ChunkedArray& actual,
+ const EqualOptions& options = TestingEqualOptions());
+ARROW_TESTING_EXPORT void AssertChunkedEqual(
+ const ChunkedArray& actual, const ArrayVector& expected,
+ const EqualOptions& options = TestingEqualOptions());
Review Comment:
yes, since AssertTablesEqual will invoke AssertChunkedEqual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
