Veeupup commented on PR #8108: URL: https://github.com/apache/arrow-datafusion/pull/8108#issuecomment-1806060518
@jayzhan211 I have implemented the array_append in MutableArray and RowConverter and it shows that Mutable performs better too. Here are the benchmarks for sqllogictests: | MutableArray | RowConverter | | ------------ | ------------ | | 29.297µs | 93.433µs | | 20.555µs | 32.201µs | | 19.251µs | 86.561µs | | 102.495µs | 143.772µs | | 58.49µs | 35.456µs | | 56.035µs | 33.316µs | | 45.607µs | 79.701µs | | 23.508µs | 33.592µs | | 22.87µs | 37.584µs | | 39.27µs | 56.071µs | | 23.973µs | 35.368µs | | 24.97µs | 37.753µs | | 44.644µs | 59.515µs | | 26.602µs | 35.498µs | | 22.272µs | 37.957µs | | 97.846µs | 169.643µs | | 107.068µs | 123.551µs | | 55.058µs | 178.546µs | | 45.853µs | 109.962µs | | 82.722µs | 90.556µs | | 43.62µs | 44.157µs | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
