alamb commented on code in PR #8114:
URL: https://github.com/apache/arrow-datafusion/pull/8114#discussion_r1389940188
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -17,6 +17,8 @@
//! DateTime expressions
+use crate::datetime_expressions;
Review Comment:
🤔 but clippy did not flag it
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -927,11 +811,19 @@ pub fn create_physical_fun(
}),
BuiltinScalarFunction::Upper => Arc::new(string_expressions::upper),
BuiltinScalarFunction::Uuid => Arc::new(string_expressions::uuid),
- _ => {
Review Comment:
👍 for removing the catchall
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -17,6 +17,8 @@
//! DateTime expressions
+use crate::datetime_expressions;
Review Comment:
🤔 but clippy did not flag it
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -927,11 +811,19 @@ pub fn create_physical_fun(
}),
BuiltinScalarFunction::Upper => Arc::new(string_expressions::upper),
BuiltinScalarFunction::Uuid => Arc::new(string_expressions::uuid),
- _ => {
Review Comment:
👍 for removing the catchall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
