felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1389966515
##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -442,6 +502,37 @@ class RecordBatchSerializer {
// Must also slice the values
values = values->Slice(values_offset, values_length);
}
+ --max_recursion_depth_;
+ RETURN_NOT_OK(VisitArray(*values));
+ ++max_recursion_depth_;
+ return Status::OK();
+ }
+
+ template <typename T>
+ enable_if_list_view<typename T::TypeClass, Status> Visit(const T& array) {
+ using offset_type = typename T::offset_type;
+
+ offset_type min_offset = 0;
+ offset_type max_end = 0;
+ {
+ std::shared_ptr<Buffer> value_offsets;
+ RETURN_NOT_OK(
+ GetZeroBasedListViewOffsets<T>(array, &value_offsets, &min_offset,
&max_end));
Review Comment:
As above, I'm following the same logic in `GetZeroBasedValueOffsets`. This
is how it is since the begining [1]. I don't know why.
[1]
https://github.com/wesm/arrow/commit/df2220f350282925a454ed911eed6618e4d53969#diff-1b1d9dca9fdea7624e22f017b8762c4919edf57c2cf43c15d59b8a5e8e1b38a5R264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
