jayzhan211 commented on code in PR #7995:
URL: https://github.com/apache/arrow-datafusion/pull/7995#discussion_r1390053054


##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -579,26 +580,51 @@ fn coerce_arguments_for_fun(
             .collect::<Result<Vec<_>>>()?;
     }
 
+    // Converting `Null` to Int32(None) to avoid handling `Null` in array 
functions

Review Comment:
   Actually converting null is not only a special case for MakeArray. I think 
we need to extend this to other Array function too. 
   
   For example, array_append(make_array(1,null,3), null);
   We not only need conversion in make_array but also conversion in 
array_append.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to