jayzhan211 commented on code in PR #7862:
URL: https://github.com/apache/arrow-datafusion/pull/7862#discussion_r1390146278
##########
datafusion/common/src/scalar.rs:
##########
@@ -1203,7 +1202,7 @@ impl ScalarValue {
scalars.into_iter().map(|x| match x {
ScalarValue::List(arr) => {
// `ScalarValue::List` contains a single element
`ListArray`.
- let list_arr = as_list_array(&arr);
+ let list_arr = as_list_array(&arr).unwrap();
Review Comment:
Cant use `?` in macro
##########
datafusion/common/src/scalar.rs:
##########
@@ -320,8 +319,8 @@ impl PartialOrd for ScalarValue {
(Fixedsizelist(_, _, _), _) => None,
(List(arr1), List(arr2)) => {
if arr1.data_type() == arr2.data_type() {
- let list_arr1 = as_list_array(arr1);
- let list_arr2 = as_list_array(arr2);
+ let list_arr1 = as_list_array(arr1).unwrap();
Review Comment:
Cant use `?` in macro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
