andygrove commented on code in PR #8132:
URL: https://github.com/apache/arrow-datafusion/pull/8132#discussion_r1390253949
##########
datafusion/common/src/dfschema.rs:
##########
@@ -34,10 +34,75 @@ use crate::{
use arrow::compute::can_cast_types;
use arrow::datatypes::{DataType, Field, FieldRef, Fields, Schema, SchemaRef};
-/// A reference-counted reference to a `DFSchema`.
+/// A reference-counted reference to a [DFSchema].
pub type DFSchemaRef = Arc<DFSchema>;
-/// DFSchema wraps an Arrow schema and adds relation names
+/// DFSchema wraps an Arrow schema and adds relation names.
+///
+/// The schema may hold the fields across multiple tables. Some fields may be
+/// qualified and some unqualified. A qualified field is a field that has a
+/// relation name associated with it.
+///
+/// Unqualified fields must unique not only amongst themselves, but also must
Review Comment:
```suggestion
/// Unqualified fields must be unique not only amongst themselves, but also
must
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
