tustvold commented on issue #5068: URL: https://github.com/apache/arrow-rs/issues/5068#issuecomment-1807215968
> Could it simply examine the character at scale + 1 and do an add_wrapping (for positives) or a sub_wrapping (for negatives) My memory is hazy, but I seem to remember the current logic eliminates the need for overflow/underflow detection, or precision verification. Provided we can show we aren't massively regressing performance of decimal parsing, I don't see an issue with changing this behaviour as you describe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
