niyue commented on PR #38677: URL: https://github.com/apache/arrow/pull/38677#issuecomment-1807373895
> Or how about using https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/io_util.h instead of std::filesystem::path for now? I am okay with that, and I can submit another PR for this change. Currently it is just an internal test file so I think it is easy to change. But we may have to document such requirement, otherwise, people submitting new PR may trigger similar issue accidentally later (I assume there are other classes in C++ 17 that could cause this issue, actually since arrow switched to C++17 for a while, I am a bit surprised that I am the first one having PR triggering such an issue). Please let me know if this is needed and I am glad to submit a PR to revise the usage of `std::filesystem::path` to `io_util.h` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
