waynexia commented on code in PR #8141:
URL: https://github.com/apache/arrow-datafusion/pull/8141#discussion_r1390589914
##########
datafusion/physical-expr/src/aggregate/sum.rs:
##########
@@ -53,11 +56,12 @@ impl Sum {
name: impl Into<String>,
data_type: DataType,
) -> Self {
- let data_type = sum_return_type(&data_type).unwrap();
+ let return_type = sum_return_type(&data_type).unwrap();
Review Comment:
`sun_return_type` doesn't cover the `List` type for now
https://github.com/apache/arrow-datafusion/blob/2ffda2a9a893455e55cd773d9dd4f426a61d8cd3/datafusion/expr/src/type_coercion/aggregates.rs#L380-L399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
