mustafasrepo commented on code in PR #8128:
URL: https://github.com/apache/arrow-datafusion/pull/8128#discussion_r1390652956


##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -203,7 +203,23 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
             .collect()
     }
 
-    /// Get the [`EquivalenceProperties`] within the plan
+    /// Get the [`EquivalenceProperties`] within the plan.
+    ///
+    /// Equivalence properties tell DataFsion what columns are known to be
+    /// equal, during various optimization passes. By default, this returns " 
no
+    /// known equivalances" which is always correct, but may cause DataFusion 
to
+    /// unecessairly resort data.
+    ///
+    /// If this ExecutionPlan makes no changes to the schema of the rows 
flowing
+    /// through it or how columns withink each row relate to each other, it

Review Comment:
   ```suggestion
       /// through it or how columns within each row relate to each other, it
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to