tustvold commented on code in PR #5070:
URL: https://github.com/apache/arrow-rs/pull/5070#discussion_r1391049509
##########
arrow-data/src/ffi.rs:
##########
@@ -282,6 +286,27 @@ impl FFI_ArrowArray {
// If dictionary is not null should be valid for reads of `Self`
unsafe { self.dictionary.as_ref() }
}
+
+ /// Create a copy of an existing `FFI_ArrowArray`
+ ///
+ /// As required by the C Data Interface specification, this sets the
`release` member of `Self`
+ /// to `None`, but without calling the release callback.
+ pub fn copy(&mut self) -> Self {
Review Comment:
Aah yes, in which case the issue is inverted. When the copy goes out of
scope the source is left with references to released memory.
Somewhere a reference count needs to be introduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
