Jefffrey commented on code in PR #5003:
URL: https://github.com/apache/arrow-rs/pull/5003#discussion_r1391077317
##########
parquet/src/column/writer/mod.rs:
##########
@@ -1170,6 +1188,7 @@ fn increment_utf8(mut data: Vec<u8>) -> Option<Vec<u8>> {
mod tests {
use crate::{file::properties::DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH,
format::BoundaryOrder};
Review Comment:
Ok, so will need to insert special case for Float16 to ensure its stats
won't get truncated
Also regarding the `BoundaryOrder` it seems it isn't being derived in
general yet, for any other types:
https://github.com/apache/arrow-rs/blob/31b5724332666d68fe94a5b3572a13a51022ea81/parquet/src/file/metadata.rs#L888-L889
I couldn't find where it might be set, so this could be a separate issue to
be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
