NGA-TRAN commented on code in PR #8113:
URL: https://github.com/apache/arrow-datafusion/pull/8113#discussion_r1391402864
##########
datafusion/proto/src/logical_plan/to_proto.rs:
##########
@@ -352,6 +352,11 @@ impl From<&StringifiedPlan> for protobuf::StringifiedPlan {
PlanType::FinalPhysicalPlan => Some(protobuf::PlanType {
plan_type_enum: Some(FinalPhysicalPlan(EmptyMessage {})),
}),
+ // Make it `todo` to avoid breaking clippy
+ // We do not want to add proto plan type for these two becasue
they are just the same as
+ // InitialPhysicalPlan and FinalPhysicalPlan
+ datafusion_expr::PlanType::InitialPhysicalPlanWithStats
+ | datafusion_expr::PlanType::FinalPhysicalPlanWithStats =>
todo!(),
Review Comment:
@alamb The `todo!` returns a panic of `not yet implemented`. Let me try
to add new types to proto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
