tustvold commented on code in PR #5070:
URL: https://github.com/apache/arrow-rs/pull/5070#discussion_r1391410897
##########
arrow-schema/src/ffi.rs:
##########
@@ -351,6 +355,9 @@ impl Drop for FFI_ArrowSchema {
}
}
+unsafe impl Send for FFI_ArrowSchema {}
+unsafe impl Sync for FFI_ArrowSchema {}
Review Comment:
Whilst it is never explicitly stated in the C Data interface, I think it is
a fairly safe assumption that data can be sent between threads - i.e. it isn't
relying on thread-local state or non-atomic reference counts, etc... Happy to
be corrected on this front though.
> I'm more confident that is true than Sync.
Sync is definitely a stronger assumption that we don't appear to need to
make here, although I also struggle to devise a sane example where it wouldn't
hold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
