alamb commented on code in PR #8146:
URL: https://github.com/apache/arrow-datafusion/pull/8146#discussion_r1391554876
##########
datafusion/sql/src/statement.rs:
##########
@@ -1098,7 +1103,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
.collect::<Vec<_>>(),
)
} else {
- let mut mapping = vec![None; table_schema.fields().len()];
+ let mut value_indices = vec![None; table_schema.fields().len()];
Review Comment:
I like the new name `value_indicies` much better
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -422,12 +422,11 @@ CopyTo: format=csv output_url=output.csv
single_file_output=true options: ()
fn plan_insert() {
let sql =
"insert into person (id, first_name, last_name) values (1, 'Alan',
'Turing')";
- let plan = r#"
-Dml: op=[Insert Into] table=[person]
- Projection: CAST(column1 AS UInt32) AS id, column2 AS first_name, column3 AS
last_name
- Values: (Int64(1), Utf8("Alan"), Utf8("Turing"))
- "#
- .trim();
+ let plan = "Dml: op=[Insert Into] table=[person]\
Review Comment:
👍
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -422,12 +422,11 @@ CopyTo: format=csv output_url=output.csv
single_file_output=true options: ()
fn plan_insert() {
let sql =
"insert into person (id, first_name, last_name) values (1, 'Alan',
'Turing')";
- let plan = r#"
-Dml: op=[Insert Into] table=[person]
- Projection: CAST(column1 AS UInt32) AS id, column2 AS first_name, column3 AS
last_name
- Values: (Int64(1), Utf8("Alan"), Utf8("Turing"))
- "#
- .trim();
+ let plan = "Dml: op=[Insert Into] table=[person]\
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
