alamb commented on code in PR #8154: URL: https://github.com/apache/arrow-datafusion/pull/8154#discussion_r1391743332
########## datafusion/physical-plan/src/joins/hash_join_utils.rs: ########## @@ -61,44 +61,45 @@ use hashbrown::HashSet; /// /// ``` text /// See the example below: -/// Insert (1,1) +/// +/// Insert (10,1) <-- insert hash value 10 with row index 1 Review Comment: I found the overloaded use of `1` as both a hash value and an index VERY confusing. Therefore I propose to use different values for the hash value and the index values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
