voidstar69 commented on PR #38680: URL: https://github.com/apache/arrow/pull/38680#issuecomment-1809245756
> I was thinking this would include all scalar arrays, e.g. TimestampArray : IReadOnlyList<DateTime?>, StringArray : IReadOnlyList, TimeXXArray : IReadOnlyList<TimeOnly?>, DateXXArray : IReadOnlyList<DateOnly?>, IReadOnlyList<DateTime?>, BooleanArray : IReadOnlyList<bool?>, BinaryArray : IReadOnlyList<byte[]>. > > The original issue also suggests implementing ICollection. > > Would you file followup work items so that this one can be marked as closed if checked-in as-is? I have implemented this for all the scalar arrays in your example. Are there any more scalar arrays that need to support `IReadOnlyList`? For `TimestampArray` it seemed more natural for it to implement `IReadOnlyList<DateTimeOffset?>`. Note that I implemented the various `GetEnumerator` methods in two distinct ways, a verbose for-loop and a concise LINQ statement. Let me know which you think is better and I will standardise on that form. I created a followup issue #38692 for adding support for `ICollection<T?>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
