niyue commented on code in PR #38698:
URL: https://github.com/apache/arrow/pull/38698#discussion_r1391881212
##########
cpp/src/gandiva/tests/test_util.cc:
##########
@@ -17,22 +17,20 @@
#include "gandiva/tests/test_util.h"
-#include <filesystem>
+#include "arrow/util/io_util.h"
namespace gandiva {
std::shared_ptr<Configuration> TestConfiguration() {
- auto builder = ConfigurationBuilder();
- return builder.DefaultConfiguration();
+ return ConfigurationBuilder::DefaultConfiguration();
Review Comment:
Previously this `DefaultConfiguration` function is called by creating a new
instance of `ConfigurationBuilder`, but I think this is not necessary since it
is a static function of `ConfigurationBuilder`, so I change it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
