felipecrv commented on code in PR #38027:
URL: https://github.com/apache/arrow/pull/38027#discussion_r1392677495
##########
cpp/src/arrow/array/data.h:
##########
@@ -434,6 +434,21 @@ struct ARROW_EXPORT ArraySpan {
return GetValues<T>(i, this->offset);
}
+ // Access a buffer's data as a span
+ template <typename T>
+ util::span<const T> GetSpan(int i) const {
+ return util::span(buffers[i].data_as<T>(),
+ static_cast<size_t>(buffers[i].size) / sizeof(T))
+ .subspan(offset);
+ }
+
+ template <typename T>
+ util::span<T> GetSpan(int i) {
+ return util::span(buffers[i].mutable_data_as<T>(),
+ static_cast<size_t>(buffers[i].size) / sizeof(T))
+ .subspan(offset);
Review Comment:
Isn't that just `.subspan(this->offset, this->length)` for the functions
defined in `ArraySpan` like the one under this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
