lidavidm commented on code in PR #1297:
URL: https://github.com/apache/arrow-adbc/pull/1297#discussion_r1393235294
##########
go/adbc/driver/snowflake/record_reader.go:
##########
@@ -567,6 +567,17 @@ func newRecordReader(ctx context.Context, alloc
memory.Allocator, ld gosnowflake
lastChannelIndex := len(chs) - 1
go func() {
+ // place this here so that we always clean up, but they can't
be in a
+ // separate goroutine. Otherwise we'll have a race condition
between
+ // the call to wait and the calls to group.Go to kick off the
jobs
+ // to perform the pre-fetching (GH-1283).
Review Comment:
Should this be placed after the loop below then? That way we absolutely know
group.Go has been called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
