llama90 commented on code in PR #38696:
URL: https://github.com/apache/arrow/pull/38696#discussion_r1393416177
##########
docs/source/format/CDeviceDataInterface.rst:
##########
@@ -627,38 +626,38 @@ streaming source of Arrow arrays. It has the following
fields:
handled by the producer, and especially by the release callback.
Result lifetimes
-----------------
+''''''''''''''''
The data returned by the ``get_schema`` and ``get_next`` callbacks must be
released independantly. Their lifetimes are not tied to that of
``ArrowDeviceArrayStream``.
Stream lifetime
----------------
+'''''''''''''''
Lifetime of the C stream is managed using a release callback with similar
usage as in :ref:`C data interface <c-data-interface-released>`.
Thread safety
--------------
+'''''''''''''
The stream source is not assumed to be thread-safe. Consumers wanting to
call ``get_next`` from several threads should ensure those calls are
serialized.
Interoperability with other interchange formats
-===============================================
+-----------------------------------------------
Review Comment:
Thank you for review. Fixed it.
##########
docs/source/format/CDeviceDataInterface.rst:
##########
@@ -627,38 +626,38 @@ streaming source of Arrow arrays. It has the following
fields:
handled by the producer, and especially by the release callback.
Result lifetimes
-----------------
+''''''''''''''''
The data returned by the ``get_schema`` and ``get_next`` callbacks must be
released independantly. Their lifetimes are not tied to that of
``ArrowDeviceArrayStream``.
Stream lifetime
----------------
+'''''''''''''''
Lifetime of the C stream is managed using a release callback with similar
usage as in :ref:`C data interface <c-data-interface-released>`.
Thread safety
--------------
+'''''''''''''
The stream source is not assumed to be thread-safe. Consumers wanting to
call ``get_next`` from several threads should ensure those calls are
serialized.
Interoperability with other interchange formats
-===============================================
+-----------------------------------------------
Other interchange APIs, such as the `CUDA Array Interface`_, include
members to pass the shape and the data types of the data buffers being
exported. This information is necessary to interpret the raw bytes in the
-device data buffers that are being shared. Rather than store the
-shape / types of the data alongside the ``ArrowDeviceArray``, users
-should utilize the existing ``ArrowSchema`` structure to pass any data
+device data buffers that are being shared. Rather than store the
+shape / types of the data alongside the ``ArrowDeviceArray``, users
+should utilize the existing ``ArrowSchema`` structure to pass any data
type and shape information.
Updating this specification
-===========================
+---------------------------
Review Comment:
Fixed it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
