pitrou commented on code in PR #38698:
URL: https://github.com/apache/arrow/pull/38698#discussion_r1393970971
##########
cpp/src/gandiva/tests/test_util.cc:
##########
@@ -17,22 +17,23 @@
#include "gandiva/tests/test_util.h"
-#include <filesystem>
+#include "arrow/util/io_util.h"
+#include "arrow/util/logging.h"
namespace gandiva {
std::shared_ptr<Configuration> TestConfiguration() {
- auto builder = ConfigurationBuilder();
- return builder.DefaultConfiguration();
+ return ConfigurationBuilder::DefaultConfiguration();
}
#ifndef GANDIVA_EXTENSION_TEST_DIR
#define GANDIVA_EXTENSION_TEST_DIR "."
#endif
std::string GetTestFunctionLLVMIRPath() {
- std::filesystem::path base(GANDIVA_EXTENSION_TEST_DIR);
- std::filesystem::path ir_file = base / "multiply_by_two.bc";
- return ir_file.string();
+ const auto base =
+
arrow::internal::PlatformFilename::FromString(GANDIVA_EXTENSION_TEST_DIR);
+ DCHECK(base.ok());
Review Comment:
```suggestion
DCHECK_OK(base);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
