tustvold commented on code in PR #8017:
URL: https://github.com/apache/arrow-datafusion/pull/8017#discussion_r1394348699


##########
datafusion/core/src/datasource/file_format/write/mod.rs:
##########
@@ -229,16 +116,6 @@ impl<W: AsyncWrite + Unpin + Send> AsyncWrite for 
AbortableWrite<W> {
     }
 }
 
-/// An enum that defines different file writer modes.
-#[derive(Debug, Clone, Copy)]
-pub enum FileWriterMode {

Review Comment:
   Given FileWriterMode::Put is not implemented by anything, and we are 
removing FileWriterMode::Append, it seemed simplest to just remove this. This 
also frees up implementations to choose an adaptive IO strategy, where they can 
determine if `Put` is appropriate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to