alamb commented on PR #8172: URL: https://github.com/apache/arrow-datafusion/pull/8172#issuecomment-1812869506
> What are your thoughts on modifying the functionalities of the precision methods instead? I mean these precision methods' logic could be replaced by the functions you removed. This is an excellent catch @berkaysynnada -- thank you. My thoughts are that I would like to initially not change any behavior unless it is clearly a bug. So in this case, I will: 1. add tests to the datasource statistics calculations so there is coverage for this behavior 2. move this code into `Precision` (as a method like `estimated_add` or something) The reason to move the code into `Precision` is to consolidate how this structure is being used (otherwise we can end up with surprises like this) > @berkaysynnada, good catch! Let's consider changing the add/max/min methods to create Inexact types when they encounter an Absent. @alamb, can you think of a case where we would need to propagate Absent if any operand is Absent? I can not. One test would be to try to change `Precision::add` and see if any tests break, though given our lack of coverage maybe this doesn't tell us as much as we would like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
