jduo commented on code in PR #38423:
URL: https://github.com/apache/arrow/pull/38423#discussion_r1394478488
##########
java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java:
##########
@@ -79,15 +84,24 @@ public final Set<Long> getDictionaryIds() {
}
@Override
- public Dictionary lookup(long id) {
+ public BaseDictionary lookup(long id) {
return map.get(id);
}
@Override
public void close() {
- for (Dictionary dictionary : map.values()) {
+ for (BaseDictionary dictionary : map.values()) {
Review Comment:
It makes sense to let the creator close. It should be documented though. The
Java codebase is somewhat inconsistent about ownership unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
