emkornfield commented on code in PR #38385:
URL: https://github.com/apache/arrow/pull/38385#discussion_r1394632592
##########
format/FlightSql.proto:
##########
@@ -1779,9 +1796,60 @@ message CommandPreparedStatementUpdate {
}
/*
- * Returned from the RPC call DoPut when a CommandStatementUpdate
- * CommandPreparedStatementUpdate was in the request, containing
- * results from the update.
+ * Represents a bulk ingestion request. Used in the command member of
FlightDescriptor
+ * for the the RPC call DoPut to cause the server load the contents of the
stream's
+ * FlightData into the target destination.
+ */
+message CommandStatementIngest {
Review Comment:
general comment, it seems like it might be cleaner to model this as two
separate operations:
1. A DDL operation to setup the table based on various conditions.
2. The bulk ingest operations.
I also worry about the slippery slope here of other options (e.g. when the
schema of the bulk data doesn't match the existing schema).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
