wjones127 commented on code in PR #8221:
URL: https://github.com/apache/arrow-datafusion/pull/8221#discussion_r1395015559
##########
datafusion/common/src/scalar.rs:
##########
@@ -1032,8 +1020,11 @@ impl ScalarValue {
ScalarValue::Binary(v) => v.is_none(),
ScalarValue::FixedSizeBinary(_, v) => v.is_none(),
ScalarValue::LargeBinary(v) => v.is_none(),
- ScalarValue::Fixedsizelist(v, ..) => v.is_none(),
- ScalarValue::List(arr) => arr.len() == arr.null_count(),
+ // arr.len() should be 1 for a list scalar, but we don't seem to
Review Comment:
If `arr.len() > 1`, it isn't a scalar. `arr` is a `ListArray` or
`FixedSizeListArray`, so `arr.len() == 1` means there is one list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
