paleolimbot commented on code in PR #313:
URL: https://github.com/apache/arrow-nanoarrow/pull/313#discussion_r1395771654
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -474,20 +481,8 @@ cdef class Array:
else:
return None
- def view(self):
Review Comment:
Yes...the `Array` as defined here doesn't know if it's a CPU or GPU array,
and the "view" does. I don't know that the `view()` method is a particularly
good idea for the `Schema`, either...a cached property might be a better fit.
Early on you made the suggestion that the `Array` and `ArrayView` were a
little confusing, name wise. I wonder if renaming the `Array` to `CArray` (+
Schema and ArrayStream) would fix some of that. Then `ArrayView` could be
renamed to `Array`, which would probably make more sense to everybody.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
