felipecrv commented on code in PR #35345: URL: https://github.com/apache/arrow/pull/35345#discussion_r1395936021
########## cpp/src/arrow/util/list_util.h: ########## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <utility> + +#include "arrow/array/data.h" +#include "arrow/result.h" + +namespace arrow { +namespace list_util { + +/// \brief Get the child array holding the values from a List or ListView array +inline const ArraySpan& ValuesArray(const ArraySpan& span) { return span.child_data[0]; } + +namespace internal { + +/// \brief Calculate the smallest continuous range of values used by the +/// var-length list-like input (list, map and list-view types). +/// +/// \param input The input array such that is_var_length_list_like(input.type) +/// is true +/// \return A pair of (offset, length) describing the range +ARROW_EXPORT Result<std::pair<int64_t, int64_t>> RangeOfValuesUsed( + const ArraySpan& input); + +/// \brief Calculate the sum of the sizes of all valid lists or list-views +/// +/// This is usally the same as the length of the RangeOfValuesUsed() range, but +/// it can be: +/// - Smaller: when the child array constains many values that are not +/// referenced by the lists or list-views in the parent array +/// - Greater: when the list-views share child array ranges +/// +/// \param input The input array such that is_var_length_list_like(input.type) +/// is true +/// \return The sum of all list or list-view sizes +ARROW_EXPORT Result<int64_t> SumOfLogicalListSizes(const ArraySpan& input); + +/// \brief Build a ListViewArray from a ListArray +ARROW_EXPORT Result<std::shared_ptr<ListViewArray>> ListViewFromList( + const ListArray& source, MemoryPool* pool); + +/// \brief Build a LargeListViewArray from a LargeListArray +ARROW_EXPORT Result<std::shared_ptr<LargeListViewArray>> ListViewFromList( + const LargeListArray& source, MemoryPool* pool); + +/// \brief Build a ListArray from a ListViewArray +ARROW_EXPORT Result<std::shared_ptr<ListArray>> ListFromListView( + const ListViewArray& source, MemoryPool* pool); + +/// \brief Build a LargeListArray from a LargeListViewArray +ARROW_EXPORT Result<std::shared_ptr<LargeListArray>> ListFromListView( + const LargeListViewArray& source, MemoryPool* pool); Review Comment: Moved all the conversion functions to the array classes now. And the tests are moved from list_util_test to list_array_test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
