paleolimbot commented on code in PR #318:
URL: https://github.com/apache/arrow-nanoarrow/pull/318#discussion_r1395990762
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -30,8 +30,11 @@ be literal and stay close to the structure definitions.
from libc.stdint cimport uintptr_t, int64_t
from cpython.mem cimport PyMem_Malloc, PyMem_Free
from cpython.bytes cimport PyBytes_FromStringAndSize
+from cpython.pycapsule cimport PyCapsule_GetPointer, PyCapsule_New
from cpython cimport Py_buffer
from nanoarrow_c cimport *
+from libc.string cimport memcpy
Review Comment:
I think this can be removed now?
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -428,6 +447,33 @@ cdef class Array:
self._ptr = <ArrowArray*>addr
self._schema = schema
+ @staticmethod
+ def _import_from_c_capsule(schema_capsule, array_capsule):
Review Comment:
I think the ordering everywhere else is `array`, `schema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
