alexwilcoxson-rel commented on code in PR #38046:
URL: https://github.com/apache/arrow/pull/38046#discussion_r1396288209
##########
csharp/test/Apache.Arrow.Flight.Tests/FlightTests.cs:
##########
@@ -52,6 +53,10 @@ private RecordBatch CreateTestBatch(int startValue, int
length)
builder.Append(startValue + i);
}
batchBuilder.Append("test", true, builder.Build());
+ var keys = new
UInt16Array.Builder().AppendRange(Enumerable.Range(startValue, length).Select(i
=> (ushort)i)).Build();
+ var dictionary = new
StringArray.Builder().AppendRange(Enumerable.Range(startValue, length).Select(i
=> i.ToString())).Build();
+ var dictArray = new DictionaryArray(new
DictionaryType(UInt16Type.Default, StringType.Default, false), keys,
dictionary);
Review Comment:
sorry have been out and had other priorities come up ArrowReaderVerifier
compares underlying dictionary arrays
https://github.com/apache/arrow/blob/1fd11d33cb56fd7eff4dce05edaba1c9d8a1dccd/csharp/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs#L175-L183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
