alamb commented on code in PR #8239:
URL: https://github.com/apache/arrow-datafusion/pull/8239#discussion_r1397425291
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -698,7 +698,11 @@ impl TryFrom<&protobuf::ScalarValue> for ScalarValue {
.map_err(DataFusionError::ArrowError)
.map_err(|e| e.context("Decoding ScalarValue::List Value"))?;
let arr = record_batch.column(0);
- Self::List(arr.to_owned())
+ match value {
+ Value::ListValue(_) => Self::List(arr.to_owned()),
+ Value::FixedSizeListValue(_) =>
Self::FixedSizeList(arr.to_owned()),
+ _ => unreachable!(),
Review Comment:
I see -- I missed the fact that this is in a `match` outer branch. I agree
this code is really unreachable. Perhaps we can make it more robust per @yukkit
's and my suggestion in some later PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
