tustvold commented on code in PR #5086:
URL: https://github.com/apache/arrow-rs/pull/5086#discussion_r1397721325
##########
arrow-select/src/zip.rs:
##########
@@ -29,19 +29,39 @@ use arrow_schema::ArrowError;
/// * `falsy` - Values of this array are taken if mask evaluates `false`
pub fn zip(
mask: &BooleanArray,
- truthy: &dyn Array,
- falsy: &dyn Array,
+ truthy: impl Datum,
Review Comment:
Switching to impl Datum will still technically be a breaking change as it
could impact type inference. I would rather we just be consistent with the
other kernels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
