kylebarron commented on code in PR #5080:
URL: https://github.com/apache/arrow-rs/pull/5080#discussion_r1397728170
##########
arrow/src/ffi.rs:
##########
@@ -234,46 +235,59 @@ pub fn to_ffi(data: &ArrayData) ->
Result<(FFI_ArrowArray, FFI_ArrowSchema)> {
///
/// This struct assumes that the incoming data agrees with the C data
interface.
pub fn from_ffi(array: FFI_ArrowArray, schema: &FFI_ArrowSchema) ->
Result<ArrayData> {
Review Comment:
Maybe the unsafe part is prior to this in casting to `FFI_ArrowArray` and
`FFI_ArrowSchema`? If you _know_ you have valid structs already, then it isn't
unsafe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
