tustvold commented on code in PR #8253:
URL: https://github.com/apache/arrow-datafusion/pull/8253#discussion_r1397741109
##########
datafusion/common/src/utils.rs:
##########
@@ -390,6 +390,16 @@ pub fn arrays_into_list_array(
))
}
+/// Get the child arrays from a `ArrayRef`.
+pub fn array_into_children_array_vec(list_arr: &ArrayRef) -> Vec<ArrayRef> {
Review Comment:
I think this handles nulls and sliced arrays incorrectly, as it ignores the
offsets and nulls on the parent. Perhaps you could just use the comparison
kernels on the lists directly, instead of partially decomposing them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
