alamb commented on code in PR #8029:
URL: https://github.com/apache/arrow-datafusion/pull/8029#discussion_r1398186233
##########
datafusion/core/src/catalog/listing_schema.rs:
##########
@@ -92,12 +92,7 @@ impl ListingSchemaProvider {
/// Reload table information from ObjectStore
pub async fn refresh(&self, state: &SessionState) ->
datafusion_common::Result<()> {
- let entries: Vec<_> = self
- .store
- .list(Some(&self.path))
- .await?
- .try_collect()
- .await?;
+ let entries: Vec<_> =
self.store.list(Some(&self.path)).try_collect().await?;
Review Comment:
that is certainly nicer
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -680,7 +680,11 @@ mod tests {
// Ensure a useful error happens at plan time if invalid casts are used
let schema = Schema::new(vec![Field::new("a", DataType::Int32,
false)]);
- let result = cast(col("a", &schema).unwrap(), &schema,
DataType::LargeBinary);
+ let result = cast(
Review Comment:
Is this change needed because arrow now supports casting Int32 -->
LargeBinary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
