tustvold commented on code in PR #8265:
URL: https://github.com/apache/arrow-datafusion/pull/8265#discussion_r1398269752
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -859,7 +859,7 @@ impl SessionContext {
// check if the file extension matches the expected extension
for path in &table_paths {
let file_name = path.prefix().filename().unwrap_or_default();
- if !path.as_str().ends_with(&option_extension) &&
file_name.contains('.') {
+ if !file_name.ends_with(&option_extension) &&
file_name.contains('.') {
Review Comment:
I think this check is just ill-formed, if the ListingTableUrl is to a
directory containing a `.` this check will reject it. I'm not sure what this
check is here for tbh...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
