mmaitre314 commented on PR #5093: URL: https://github.com/apache/arrow-rs/pull/5093#issuecomment-1817677472
> As I've made some non-trivial modifications I intend to leave this open for until Monday, to give other reviewers time to comment Thanks! The update looks good to me. The one piece I would keep out would be the use of `from_env()`, because it changes the scenario. It looks like `from_env()` assumes there is a single Storage Account with a single Container and only the Blob Path changes each time, which is not very typical in data pipelines where datasets may come from different teams and may be partitioned to avoid throttling, to implement different access control lists, or abide by different regional regulatory requirements. The one boiler-plate line is `.with_use_azure_cli(true)`. Were an official Azure SDK available, this would not be there and instead `DefaultAzureCredential` would be used to handle auth transparently and have the same code run during local development and remote deployment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
