amassalha commented on code in PR #38272:
URL: https://github.com/apache/arrow/pull/38272#discussion_r1398404710
##########
cpp/src/arrow/util/compression_zlib.cc:
##########
@@ -392,40 +395,48 @@ class GZipCodec : public Codec {
return 0;
}
- // Reset the stream for this block
- if (inflateReset(&stream_) != Z_OK) {
- return ZlibErrorPrefix("zlib inflateReset failed: ", stream_.msg);
- }
+ // inflate() will not automatically decode concatenated gzip members, keep
calling
Review Comment:
yes this means to continue calling inflate and concatenating inflate results
until reading(inflatting) all input data
I put it on the while condition to epxplain the reason behind it
Do you think it should be on the inflate call? or somwhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
