pitrou commented on code in PR #38272:
URL: https://github.com/apache/arrow/pull/38272#discussion_r1399185291
##########
cpp/src/arrow/util/compression_test.cc:
##########
@@ -368,6 +368,42 @@ TEST_P(CodecTest, CodecRoundtrip) {
}
}
+TEST(CodecTest, CodecRoundtripGzipMembers) {
+ std::unique_ptr<Codec> gzip_codec;
+ ASSERT_OK_AND_ASSIGN(gzip_codec, Codec::Create(Compression::GZIP));
+
+ for (int data_half_size : {0, 10000, 100000}) {
+ int64_t actual_size_p1, actual_size_p2;
+ std::vector<uint8_t> data_half = MakeRandomData(data_half_size);
+ std::vector<uint8_t> data_full(data_half.begin(), data_half.end());
+ data_full.insert(data_full.end(), data_half.begin(), data_half.end());
Review Comment:
This test is deliberately trivial:
1. the two members have the same length
2. they have the exact same content
Can you please make the test more relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
