mustafasrepo opened a new pull request, #8281: URL: https://github.com/apache/arrow-datafusion/pull/8281
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Improves the situation on [#8064](https://github.com/apache/arrow-datafusion/issues/8064) ## Rationale for this change Currently we cannot determine whether ordering requirement of the complex expressions are satisfied. Consider the case where requirement is `[a+b ASC]`, and we know that existing orderings are `[a ASC], [b ASC]`. It should be possible to understand that given `[a ASC] and [b ASC]`, requirement: `[a+b ASC]` is satisfied (Please note that we already have mechanism to make deduction. However, it is not considered in requirement satisfaction analysis. Currently we search requirement among existing orderings, this limits our ability during analysis). <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? This PR re-implements the `find_longest_permutation` and `ordering_satisfy_requirement` so that ordering of the complex(composed) expressions are calculated correctly, and considered during analysis. Most of the changes comes from the tests, and test related changes. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Yes. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
