comphead commented on code in PR #8286:
URL: https://github.com/apache/arrow-datafusion/pull/8286#discussion_r1399637625
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -257,16 +257,13 @@ fn get_field_metadata(
e: &Arc<dyn PhysicalExpr>,
input_schema: &Schema,
) -> Option<HashMap<String, String>> {
- let name = if let Some(column) = e.as_any().downcast_ref::<Column>() {
- column.name()
- } else {
- return None;
- };
-
- input_schema
- .field_with_name(name)
- .ok()
- .map(|f| f.metadata().clone())
+ // Look up field by index in schema (not NAME as there can be more than one
+ // column with the same name)
+ e.as_any()
+ .downcast_ref::<Column>()
+ .map(|column| column.index())
+ .map(|idx| input_schema.field(idx).metadata())
Review Comment:
this can likely be done within a single `map`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
